ACK. This is slightly different from the refactoring in "v4" (as tls_session_generate_data_channel_keys() is now "static" and no longer needs to be called externally, so the actual change is much smaller). The change to ssl.c is mostly identical, though, so this was now reviewed and tested twice :-) - "just code being moved around". Passes all tests on server and client side.
Your patch has been applied to the master branch. commit e2ffdb7c83faaee6541c248e8d83eb3dfb5a32f1 Author: Steffan Karger Date: Wed Nov 23 21:02:05 2016 +0100 Refactor data channel key generation API Signed-off-by: Steffan Karger <stef...@karger.me> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1479931325-25919-2-git-send-email-stef...@karger.me> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13216.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering ------------------------------------------------------------------------------ _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel