Hi, On 05-11-16 06:52, Илья Шипицин wrote: > I'm geting "build only" travis-ci mingw cross compile config > and I came to idea that I do not understand why "tap-windows.h" must be > downloaded separately > > 1) if we use some functions, we should include prototypes. it is not > very common to download prototypes from different location
When using external dependencies it is *not* a best practice to include the headers of that dependency (or even worse, binaries) into your own project repository. I haven't seen any decent C project do that. We wouldn't include the OpenSSL, mbed TLS or even libc headers either, would we? > 2) such way requires also complicated things like configure checks > (which in turn may be avoided if we include tap-windows.h) configure checks are there to help you simplify dependency management. Our configure.ac might be a bit convoluted, so surely qualified for improvement, but setting a few paths isn't that hard, is it? > so, I guess, there're might be legal issue ? > if not, I vote for adding tap-windows.h into openvpn repo. > it will simplify things a lot I do not believe there are legal issues, but for the reasons above I vote against including the tap-windows headers into the core openvpn repo. So, Feature-NAK. -Steffan ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
