Hi,
On Mon, Aug 8, 2016 at 3:28 PM, David Sommerseth <dav...@openvpn.net> wrote:
> In systemd after version 216, systemd-ask-password will support --echo
> which
> will avoid masking the user input. As OpenVPN uses this mechanism
> collecting
> usernames when systemd is available, this will avoid the input of
> usernames to
> be masked.
>
Good to see support for --echo.
>
> diff --git a/configure.ac b/configure.ac
> index c3088fd..a44e1df 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1023,6 +1023,7 @@ if test "$enable_systemd" = "yes" ; then
> AC_CHECK_FUNCS([sd_booted], [], [AC_MSG_ERROR([systemd library is
> missing sd_booted()])])
> OPTIONAL_SYSTEMD_LIBS="${libsystemd_LIBS}"
> AC_DEFINE(ENABLE_SYSTEMD, 1, [Enable systemd integration])
> + AC_DEFINE_UNQUOTED(SYSTEMD_VERSION, [`echo
> ${libsystemd_MODVERSION}`], [systemd version installed])
>
PKG_CHECK_MODULES() only defines prefix_LIBS and prefix_CFLAGS not
prefix_MODVERSION. So how does libsystemd_MODVERSION get defined? Is there
a new version of pkg.m4 that does this?
With undefined libsystemd_MODVERSION, SYSTEMD_VERSION will get defined with
no value causing SYSTEMD_VERSION > 216 check during compile to error.
By the way, `echo ${libsystemd_MODVERSION}` is very convoluted -- why not
write it simply as
AC_DEFINE_UNQUOTED(SYSTEMD_VERSION, [${libsystemd_MODVERSION}], [systemd
version installed])
Selva
