On Sun, Jun 12, 2016 at 8:09 PM, Gert Doering <g...@greenie.muc.de> wrote: > On Sun, Jun 12, 2016 at 07:56:50PM +0200, Steffan Karger wrote: >> > Can we detect and #ifdef this at build time? >> > >> > Yes, adding another #ifdef is what we try to avoid - but this is a fairly >> > localized thing, and the dependency is clear, not a "user selectable >> > combination of build options". >> >> Sure. We can put this in e.g. #ifndef ENABLE_SMALL. > > Was more thinking along the line of > > #if !defined(ENABLE_SMALL) && !defined(MBEDTLS_COMPILED_WITH_SILLY_OPTION) > > because --enable-small would remove lots of other useful information... > >> This information is not just useful for debugging during development, >> but also for debugging user problems. So I'd rather keep it in there >> by default, most users don't care at all about 40 kB :) > > As far as I understood, if you build mbedtls without this debug.o, linking > OpenVPN would just *fail* today.
Right, of course. Sorry - too tired today. That would be #ifdef MBEDTLS_DEBUG_C, and totally makes sense. I'll send a patch. -Steffan
