ACK.
Stared at the code, and managed to reproduce the race by pressing ctrl-c
at exactly the right spot (shortly before the "pull-filter reject" would
trigger a SIGUSR1) and saw my ctrl-c being ignored - with the patch, things
work as expected:
Tue Jun 7 23:00:08 2016 us=714409 Ignoring SIGUSR1 received during exit
notification
As we have discussed, this is not "the perfect solution" yet, but I think
it solves the "large" race condition (during the explicit-exit-notify
time window) without making code elsewhere even more complicated. We
should continue working on this, though, and eventually get rid of this
workaround again :-)
As this is bugfix it goes into release/2.3.
Your patch has been applied to the master and release/2.3 branch.
commit 63b3e000c9141f4ca03a374354da26334257bc18 (master)
commit 859c9f412455665635964519f3e44a0b4151a787 (release/2.3)
Author: Selva Nair
List-Post: openvpn-devel@lists.sourceforge.net
Date: Tue Jun 7 00:44:20 2016 -0400
Ignore SIGUSR1/SIGHUP during exit notification
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <1465274660-11009-2-git-send-email-selva.n...@gmail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/11814
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
