Hi,

On Sat, Jun 04, 2016 at 01:17:25AM -0400, Selva Nair wrote:
> The joy was short-lived. mingw cross-compile from release/2.3 tarball is
> also broken:
> 
>     error: cannot find input file: `vendor/Makefile.in'
> 
> Thankfully, cherry-pick 41ab12f06253c fixes it.

I have cherry-picked 41ab12f06253c this for the time being into release/2.3:

commit b76acd72cd8ea295b925e058336440ff819ca8f4
Author: David Sommerseth <d...@privateinternetaccess.com>
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Fri Jun 3 18:56:20 2016 +0200

    Another fix related to unit test framework

    Signed-off-by: David Sommerseth <d...@privateinternetaccess.com>
    Acked-by: Gert Doering <g...@greenie.muc.de>
    Message-Id: 
<1464976163-6162-1-git-send-email-open...@sf.lists.topphemmelig.net>
    URL: http://article.gmane.org/gmane.network.openvpn.devel/11778
    (cherry picked from commit 41ab12f06253cadc34fc47da865178de3db0bbdc)


> IMO, the unit testing patches shouldn't have been merged into the release
> branch

I have discussed this with David (after the fact, meh) and we couldn't 
really come to an conclusion on this - but since you and Jens now both
argue that way (and especially Jens as the original author should have
some authority here :-) )  I think we'll revert the four relevant patches
again.  Looks silly, but keeping stuff in a tree where we did not want
it to go in the first place, and then spending time maintaining it there
looks even more silly to me...

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

Reply via email to