ACK. Thanks a lot, and sorry for the delay in reviewing. I've stared at the code, and it looks good to me (very clean code, if I may say so :-) ) - the openvpn code is definitely good, the iservice code "looks reasonable", though I might be missing some windows intricacies.
Compile-tested on my mingw test environment, but have not run it yet - I'm going to be lazy and wait for Samuli's build snapshot. Your patch has been applied to the master branch. commit 3e42a558103e4e3f45ed28ccb761cefed20e8247 (master) Author: Selva Nair List-Post: [email protected] Date: Thu Mar 10 23:47:26 2016 -0500 Add support for register-dns through interactive service Signed-off-by: Selva Nair <[email protected]> Acked-by: Gert Doering <[email protected]> Message-Id: <[email protected]> URL: http://article.gmane.org/gmane.network.openvpn.devel/11354 Signed-off-by: Gert Doering <[email protected]> -- kind regards, Gert Doering
