On Thu, Apr 21, 2016 at 9:12 AM, Jens <openvpn-de...@neuhalfen.name> wrote: > What are your thoughts? Should we add unit tests at all? What would be your > preferred way for dependency management. Please defer discussion on /which/ > unit testing framework to use until we have an agreement on the /if/ and > /how/ (just to prevent the ‘paint the bike shed’ discussion).
Yes, adding unit tests (or at least, a working framework to create unit tests) is welcome. We should realize that a large part of the 2.x codebase is really hard to test this way, but for those parts we can isolate, this still makes sense. We currently do dependency management through configure / autoconf. It's not perfect, but we have it in place. I think I'd prefer using that for a test framework too, if possible (ie, if 'link to libxyztest' suffices). I recognize the risk of bike shedding, but I'm afraid the way we would integrate a test framework greatly depends on how it works... Do you know what are common C test suites / do you have any suggestions? (For C, I've only worked with proprietary test suites before). -Steffan
