ACK.

https://msdn.microsoft.com/en-us/library/windows/desktop/ms682396(v=vs.85).aspx
explains the behaviour described in trac#666 (only a single thread is 
stopping, all the rest does not receive the event due to auto-reset 
behaviour).

I'm not sure if the ResetEvent() call is actually needed but it's certainly
good style to acknowledge in the master thread after all clients are done.

Your patch has been applied to the master branch.

commit 239d09938b300f8eafa12bfb8c43373f0215f7bd
Author: Selva Nair
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sun Mar 6 00:19:19 2016 -0500

     Fix interactive service ignoring stop command if openvpn is running

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <1457241559-23374-1-git-send-email-selva.n...@gmail.com>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/11317
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering


Reply via email to