Hi,

While reviewing the series of patches from Wayne Davison, I've come to
realize that, until the recent changes in get_user_pass_cr, the use of
challenge-response was incompatible with reading auth-user-pass from a
file. As this goes back to early 2.3-alpha, it may be by design, but not
documented as such?

Anyway, as a side effect of the "username-only" commit (6e9373c846..), now
static-challenge gets prompted from console when only username is read from
a file. Dynamic challenge remains incompatible (i.e., broken if auth_file
is defined).  It looks useful and worthwhile to make this more consistent
by reading the response to the challenge from console in all cases (except
when query from management is enabled, of course).

This can be done by a few lines of changes to the code, but I would like to
hear what others think about the following options:

(a) leave as is and document that challenge-response is incompatible with
user and pass from file

OR

(b) prompt for the response from console in both dynamic and static cases

OR

(c) something else

Prompting from management works fine as long as auth-user-pass file is not
set.

If there is no strong preference, I'll submit a patch for (b) acknowledging
Wayne Davison who brought this up.

Thanks,

Selva

Reply via email to