Hi,
On Tue, Dec 15, 2015 at 05:10:57PM -0500, Selva Nair wrote:
> > Well, it is not an "unknown option" on XP... and the code doesn't really
> > lend itself to "just claim it's an unknown option if it cannot be enabled"
> > without being truly ugly...
>
> Well,
> else if (streq (p[0], "block-outside-dns") && !p[1] && win_wfp_init_funcs())
> {..
> }
> will do it, but then one can't print a helpful error for the XP folks.
Thinking about it again, we could indeed print the "helpful error for XP"
inside win_wfp_init_funcs(), and then use the code the way you propose
(and it's less ugly than I feared).
But it will still be confusing then, to see a message about "cannot load
WFP modules!" and, after that, "unknown option!"...
For 2.3.9, let's just leave it as it is and get it *out*. Revisit later,
if sufficient user confusion is detected :-)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
