Hi,
Though nothing breaks, this leads to confusing code fragments like the one
around this one
@@ -1143,7 +1142,7 @@ get_user_pass_cr (struct user_pass *up,
> { msg(M_FATAL, "neither stdin nor stderr are a tty device,
> can't ask for %s password. If you used --daemon, you need to use --askpass
> to make passphrase-protected keys work, and you can not use
> --auth-nocache.", prefix ); }
> #endif
>
> -#ifdef ENABLE_CLIENT_CR
> +#ifdef ENABLE_MANAGEMENT
> if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_CHALLENGE))
> {
> struct auth_challenge_info *ac = get_auth_challenge
> (auth_challenge, &gc);
>
would read as "Ifdef ENABLE_MANAGEMENT, read the challenge response from
stdin".
Why not unconditionally enable the challenge-response support irrespective
of whether MANAGEMENT is enabled or not? That will get rid of all those
ifdefs. I don't see any obvious downsides.
Thanks,
Selva
