Hi, On Thu, Nov 26, 2015 at 7:53 AM, Gert Doering <g...@greenie.muc.de> wrote:
> On Thu, Nov 26, 2015 at 12:15:32AM -0500, Selva Nair wrote: > > Commit 6e9373c846.. introduced a bug by which auth-user-pass > > input falls back to read-from-stdin after successfully reading > > from management. > > Mmmmh. I was all willing to merge the other one - That one fixed my use case but will break others.. Sorry, I should have tested more before posting.. > but this one looks > like a workable alternative as well, just tell the subsequent code > "we're done, no need to query anymore". > Yeah, it ain't pretty. Who uses three bools to handle four cases? For cleaner code I would kill the bools and get a flag. I hate bools :-) But, that would entail extensive testing --- I guess, leave it for some other time when more changes are made in the context. > > Any other variants that could trigger this? Tested these cases: user from file, pass from stdin; both from file, both from stdin and both from management with retries triggered by failed auth. But now that you ask, looked again and I suspect the NEED_OK case also may trigger the fall back to stdin. That's used when a token is inserted right? Will try to trigger that and see. All this to save a feature of dubious utility[*]? Selva [*] Well, windows users with a 16 wchar username and two embedded spaces but 4 char password of "test" may want to save typing username again and again... Sorry, I'm irked by a patch that broke my vpn :-)
