Ho Hum, On Tue, Nov 24, 2015 at 05:45:04PM +0100, Heiko Hund wrote: > Add missing environment variables for IPv6 virtual addresses: > > * ifconfig_pool_local_ipv6 > * ifconfig_pool_remote_ipv6 > * ifconfig_pool_ipv6_netbits > > Signed-off-by: Heiko Hund <heiko.h...@sophos.com> [..]
There's two problems with it, unfortunately... first problem is that your
exchange server ("Received:" header #1) seems to stubbornly mangle all
tabs into 8 spaces - so the context of the patch does not match the
context in tree, and the patch doesn't apply. Since sophos *does* have
a real MTA (postfix) further down the line - could that one be used
directly...?
But this is just a secondary thing for this patch as the patch is small
(so I could fix this by hand) - more complicated is this one:
> void
> +setenv_in6_addr (struct env_set *es,
> + const char *name_prefix,
> + const struct in6_addr *addr,
> + const unsigned int flags)
> +{
> + if (!IN6_IS_ADDR_UNSPECIFIED (addr) || !(flags & SA_SET_IF_NONZERO))
> + {
> + struct openvpn_sockaddr si;
> + CLEAR (si);
> + si.addr.in6.sin6_family = AF_INET6;
> + si.addr.in6.sin6_addr = *addr;
> + setenv_sockaddr (es, name_prefix, &si, flags|SA_NO_IP_SUFFIX);
... what does "SA_NO_IP_SUFFIX" do? I've searched release/2.2, 2.3 and
git master, and couldn't find any trace of it - so it's not something
we lost during socket.c rewrite, but seemingly something we never
received...
I assume it is related to this stuff...
openvpn_snprintf (name_buf, sizeof (name_buf), "%s_ip", name_prefix);
openvpn_snprintf (name_buf, sizeof (name_buf), "%s_ip6", name_prefix);
... tacking a _ip(6) suffix to the name_prefix (or specifically, "not").
Where else do you use that? Is this something we'd want to have?
thanks,
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
