On 16.11.2015 09:17, Selva Nair wrote: > Hi, > > Here are some comments on the code -- there is one apparent memory leak (see > below). > > > the word "external" is not required nor appropriate as it blocks all, isn't > it?
I'm not a native speaker. If you say that, probably you're right. > > > This error/warning is unnecessary and confusing. If the user does not want to > block-outside-dns, why say "can't block"? And why the "without configured DNS > server" remark? That's a garbage. There used to be a check for configured 'dhcp-option DNS' and I forgot to remove that. Thanks. > > in win32.c > + > + ret = ConvertInterfaceIndexToLuid(index, &tapluid); > + if (ret == NO_ERROR) > + dmsg (D_LOW, "Tap Luid: %I64d", tapluid.Value); > + > > Is it safe to ignore the ret != NO_ERROR case? May be it is... > > > openvpnblob is allocated here, but not freed anywhere. Need to free it before > return. > > Finally, to nitpick, > There are a couple of unused variables > Some local vars could be eliminated (rpcStatus, dwFwAPIRetCode, ret) > FIREWALL_NAME defined as const, but passed to non-const > ZeroMemory --> CLEAR > CopyMemory --> memcpy > > Regards, > > Selva
signature.asc
Description: OpenPGP digital signature
