Hi,

    Since the new server side code does not actually *do* OCC any more we
    are just #ifdef'ing it to access options->ce.explicit_exit_notify
    because that one is only compiled in #ifdef ENABLE_OCC ... so we're
    coupling this new functionality to an #ifdef which is not really
    relevant.

    No good suggestion yet, just expressing thoughts...


Since connection_entry->explicit_exit_notification is now used also outside of OCC context, I suggest to:

1) Remove #ifdef ENABLE_OCC around it's definition.

2) Fix comment there:

/* Explicitly tell peer when we are exiting via OCC_EXIT or control channel [RESTART] message */

3) Remove (unneeded anymore) #ifdef in multi_process_signal around accessing explicit_exit_notification.

What do you think?

-Lev





Reply via email to