Hi, On Thu, Oct 22, 2015 at 04:09:20PM +0300, Lev Stipakov wrote: > From: Olli Mannisto <olmanni...@gmail.com> > > Some windows machines get weird issues with netsh when using > adapter name on "netsh.exe interface ipv6 set address" command. > > Changed logic to get adapter index and use it instead of adapter > name for netsh set address command. if unable to get adapter index, > try with adapter name.
NAK on that - it's extra code, another "two branches that need testing" addition, and I have not seen any mention of these "weird issues" yet - so please explain the problem scenario better. (I might be happy to go for "use adapter index, always!", but I really *really* do not want "try this, fall back to that!" unless it's well understood why this is needed). Also, I wonder why this is not needed for route addition if it's needed for ip address setting.. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature