Hi, On Tue, Sep 15, 2015 at 11:23:32AM +0200, Arne Schwabe wrote: > This not done via android_control since calling management from management > leads to an infinitive loop
I'm all willing to ACK it, but...
> +#ifdef TARGET_ANDROID
> +int
> +managmenet_callback_network_change (void *arg)
^^^
... the typo police is not letting me.
> @@ -3173,6 +3204,9 @@ init_management_callback_p2p (struct context *c)
> cb.show_net = management_show_net_callback;
> cb.proxy_cmd = management_callback_proxy_cmd;
> cb.remote_cmd = management_callback_remote_cmd;
> +#ifdef TARGET_ANDROID
> + cb.network_change = managmenet_callback_network_change;
> +#endif
As the typo is here as well, it *works*, but we should still fix it :)
All the rest looks good, as in "only touches Android anyway, but even
there, pointer accesses are checked, in line with the rest, etc."
Shall I just fix the typo, ACK and commit, or do you want to re-send?
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpUTkbFD12Q4.pgp
Description: PGP signature
