Am 14.04.2015 um 20:34 schrieb Yegor Yefremov: > Signed-off-by: Yegor Yefremov <yegorsli...@googlemail.com> > --- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 9132468..ca0d9c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -374,6 +374,9 @@ AC_DEFINE_UNQUOTED([IPROUTE_PATH], ["$IPROUTE"], [Path to > iproute tool]) > AC_DEFINE_UNQUOTED([ROUTE_PATH], ["$ROUTE"], [Path to route tool]) > AC_DEFINE_UNQUOTED([SYSTEMD_ASK_PASSWORD_PATH], ["$SYSTEMD_ASK_PASSWORD"], > [Path to systemd-ask-password tool]) > > +# enable silent build > +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes]])) > + > # > # Libtool > # >
Thanks for the proposal. NAK, on these grounds: - the m4_ifdef() makes the Makefile behaviour dependent on automake version used, hence inconsistent across developer distros. This potentially causes confusion. - it changes policy through the [yes] argument to AM_SILENT_RULES(). This flips the switch for the default without good reason, and that makes debugging harder - this is a policy decision, not mechanism. If the oldest distro we need to support (James? Samuli?) offers "silent-rules" through AM_INIT_AUTOMAKE, we should just add it there, but we should not touch the default. Then still anyone can call "make V=0" or ./configure --enable-silent-rules and hide the output details. Or else you can always "make -s". This patch changes all the command line output from Make to something like: CC openvpn.o CC route.o LD openvpn thus hiding compiler options, linker and -I flags and thereabouts.
signature.asc
Description: OpenPGP digital signature