On 24/10/14 15:20, Gert Doering wrote: [...snip...] > ... please don't do whitespace changes in places where no code changes > (as it makes it harder to see where changes happened) [...snip...] > Here's an escaped tab-to-space conversion or so, but "just whitespace > change" nonetheless. [...snip...] > Whitespace...
As there were a lot of "whitespace" issues here, I'd recommend you to
enable colours in git. This will highlight many of the whitespace
issues here. Just add this section to either your global git config
(~/.gitconfig) or directly your git tree config (.git/config):
[color]
branch = auto
diff = auto
log = auto
interactive = auto
status = auto
pager = true
Some might find it useful to also have this:
[core]
pager = less -X -R -F
When the patch is "complete", it would also help us maintainers if you
do 'git add' on the files you've changed (see git status) and then do a
commit (git commit -s) with a describing commit message (describe the
patch in a non-technical manner [1]). Then you can use 'git
format-patch HEAD~1' to get the last commit as patch. See our quick git
crash course [2] for more things you can do with git, like sending mails
directly from gi.
[1] <http://who-t.blogspot.no/2009/12/on-commit-messages.html>
[2] <https://community.openvpn.net/openvpn/wiki/GitCrashCourse>
--
kind regards,
David Sommerseth
signature.asc
Description: OpenPGP digital signature
