On 03/10/14 16:47, Mike Gilbert wrote:
>> +AC_ARG_VAR([SYSTEMD_LIBS], [linker flags for systemd])
>> +if test "$enable_systemd" = "yes" ; then
>> +    AC_CHECKING([for systemd Library and Header files])
>> +    havesystemdlib=1
>> +
>> +    # if SYSTEMD_LIBS is set, we assume it will work, otherwise test
>> +    saved_LIBS="${CFLAGS}"
>> +    LIBS="${LIBS} ${SYSTEMD_LIBS}"
>> +    if test -z "${SYSTEMD_LIBS}"; then
>> +       AC_CHECK_LIB(systemd-daemon, sd_booted,
>> +           [ SYSTEMD_LIBS="-lsystemd-daemon" ],
>> +           [
>> +               AC_MSG_ERROR([systemd-daemon library not found.])
>> +               havesystemdlib=0
>> +           ])
>> +    fi
> 
> Checking for libsystemd-daemon this way will fail with newer releases
> of systemd (>= 209), where all systemd libs have been consolidated
> into a single "libsystemd".

Whoops!  Didn't know that.

> Also, why not use PKG_CHECK_MODULES here?

Good catch!  Actually, it was a copy-paste of a section earlier in the
file I knew worked.  But I agree, using PKG_CHECK_MODULES is more
appropriate.

/me goes to prepare a v2 patch

-- 
kind regards,

David Sommerseth

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to