Hi, (why is this being discussed on -users? Taking it over to -devel)
On Thu, May 01, 2014 at 09:52:45PM -0400, Timothe Litt wrote:
> e.g. the following are valid:
> --daemon
> Daemonize, use the default progname (from PACKAGE)
> for syslog
>
> --daemon my-vpn-daemon
> Daemonize, use "my-vpn-daemon" for the syslog progname.
>
> --daemon [local1]
> Daemonize, use the default progname, use the local1
> syslog facility (unless --syslog-facility already specified one)
>
> --daemon my[local1]-vpn-daemon --daemon
> [local1]my-vpn-daemon --daemon my-vpn-daemon[local1]
> Daemonize, use "my-vpn-daemon" for the syslog
> progname.
> Use the local1 syslog facility
> (unless --syslog-facility already specified one)
Uh. Feature-NAK - especially the last one really makes me want to throw up.
Using [] as part of an option string is a bad idea, because it is commonly
used for optional arguments (as you saw in David's question), and intermixing
option argument "A" and "B" in the same string is not going to help anyone.
If we take this at all - and I have reservations, because the amount of
code it brings in is quite significant - it should not touch the --daemon
command line. It brings it's own config statement (--syslog-facility),
so there really is no reason to mess up the syntax for --daemon.
Also, --syslog-facility should be more clean, like
--sysloc-facility facility [progname]
with "progname" actually being *optional*, not "marked by using rectangular
brackets".
[..]
> As I explain above, this is to make it possible to specify a facility
> name in cases where the system init script uses --daemon before the user
> can put a --syslog-facility. --syslog-facility must precede --daemon or
> --syslog because the latter two immediately switch logging to syslog;
> they are what consume the facility code when they call openlog().
Init scripts can be adjusted. Obscure code inside OpenVPN stays forever
(guess why the developers have so little time? right, maintaining stuff
that someone else considered "a clever hack" 5 years ago).
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpR2GjqX4Ja9.pgp
Description: PGP signature
