Hi, On Fri, Mar 28, 2014 at 11:07 AM, Arne Schwabe <a...@rfc2549.org> wrote:
> Commit 7d5e26cbb53 fixed extracting serial but did not change the format, > which always has been decimal. This patch fixes the manpage and > OSCP.sh script to conform with the implementation. > --- > [diff] > NACK, because glancing over the code tells me PolarSSL builds do use hex strings. So this fixes the inconsistency between implementation and manpage for OpenSSL builds, but adds inconsistency for PolarSSL builds. I see three options here: 1 - Leave the difference, explain in the manpage. 2 - Change PolarSSL builds to use dec representation 3 - Change OpenSSL builds to use hax representation I tend towards "just update the manpage". Changing PolarSSL builds to dec needs changes in PolarSSL, or manually parsing the serial in OpenVPN. Changing OpenSSL builds to hex is trivial but breaks backward compatibility. Any other opinions? -Steffan
