Hi, On Thu, Mar 21, 2013 at 06:41:04PM +0100, Steffan Karger wrote: > Attached an updated version of the patch, which should resolve the issue. It > passes t_client tests.
It does! OCC is happy now, keysize defaults to 128 bits now, so I am
happy to report that
"release/2.3 plus your most recent patches 1-6"
will a) compile with polar 1.2.6 (on FreeBSD), and b) pass all my t_client
tests as well with all cipher/crypto related options "at default", talking
to an openssl-openvpn server, also "all options at default":
Test sets succeded: 1 1a 2 2a 2b 3 4 4a 5.
Test sets failed: none.
So there's an ACK from me as well (tested and stared at the code).
Now, due to adding a "patch 6/5" to the series afterwards, and sending
new versions of patch 1 and patch 4, the whole mail thread is a bit
confusing now. Since we're aiming for maximum transparency regarding
"which bits go in the tree and why", may I ask you to "git send-email"
these 6 patches in their most recent version in one new thread again
(and Adriaan to ACK *those* as well)?
That way we'll have a definite patch set in one single thread, and I
can merge that with less chance of accident.
thanks in advance, and for the work done this week!
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpJG8DW5nYFD.pgp
Description: PGP signature
