Am 20.03.13 17:32, schrieb Josh Cepek:
> This patch adds a log warning when using --verb levels at 7 or higher
> when running on builds lacking debug support. Since official builds are
> now built with enable_debug=no, this warning will help developers
> identify why expected debug messages may not be present in log output.
>
> The test and message output code is omitted when built with
> enable_debug=yes or enable_small=yes.
>
> Signed-off-by: Josh Cepek <josh.ce...@usa.net>
> ---
> src/openvpn/options.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/openvpn/options.c b/src/openvpn/options.c
> index 2eb4f91..7f8940c 100644
> --- a/src/openvpn/options.c
> +++ b/src/openvpn/options.c
> @@ -4672,6 +4672,12 @@ add_option (struct options *options,
> {
> VERIFY_PERMISSION (OPT_P_MESSAGES);
> options->verbosity = positive_atoi (p[1]);
> +#if !defined(ENABLE_DEBUG) && !defined(ENABLE_SMALL)
> + /* Warn when a debug verbosity is supplied when built without debug
> support */
> + if (options->verbosity >= 7)
> + msg (M_WARN, "NOTE: a debug verb level (--verb %d) is enabled, but
> this build lacks debug support.",
> + options->verbosity);
> +#endif
> }
> else if (streq (p[0], "mute") && p[1])
> {
ACK. But I would change "debug verb" to "debug verbosity" and I think
there should be no comma before "but"
