Am 21.02.13 17:53, schrieb Josh Cepek: > The patch is attached; a summary, and mitigating build suggestion follows: > > The current official Windows builds of 2.3.0 up to I004 are built > enable_debug=no; I'm not sure about the repo builds since I build from source > on my non-Windows systems, but the same issue is present when lacking debug > support on Linux/Unix. This causes such builds to lack parameter printing at > --verb 4 which conflicts with the help output and configure text for > enable_small. This is a particular issue for binary installations (Windows, or > binary *nix distros.) > > Until this change makes its way into the release repo branches, I'd suggest > all official builds be built with enable_debug=yes. Without this build option, > end-users will be unable to make use of increased verbosity/troubleshooting > provided at verb 4. > > > Commit/code reasoning for the patch: (also present in attached patch for > convenience.) This patch applies to either the v2.3.0 tag, or current HEAD. > > When built with enable_debug=no, the parameter output expected at --verb 4 is > not printed due to use of #ifdef ENABLE_DEBUG in the responsible code > sections. This appears to be a mistake when looking at the configure help text > for enable_small and enable_debug. > > This change keys the relevant code off of enable_small instead, including the > parameter listing when enale_small=no (the configure-script default.) Most of > this code is in options.c, with some callers present in plugin.c/h and > route.c/h. No function code is changed, just the #ifdef values to use the > small feature instead of debug. > > This means builds no longer need enable_debug=yes in order to get the expected > log output at verb 4. > Ack to the patch. I think it is reseanable to show the parameters in higher debug output but enable_debug also enables *a lot* of other output. Can you add a second patch or modify this patch to print a warning at verb 7 (after a quick look all dmsg output are >= verb 7) that debug is not enabled and messages from the output might be missing?
Arne
