Hi, On Tue, Jan 29, 2013 at 11:55:25AM +0100, Joerg Willmann wrote: > The patch attached to #172 solved my problem and seems to be reasonable. > > I'm just wondering what it takes to make this issue being accepted. (Sorry > I didn't find a description of this process in > wiki/DeveloperDocumentation). > Does it just take time or is some input required?
Thanks for your patience. I have now committed this to master and
release/2.3, and will push ASAP.
commit f8ac53b98ed2513f1d80363b6fd2351f1b4ae511 (master)
commit 55058d4f96dfec96e9f0cad7802a5eaaf9a3301f (release/2.3)
Author: Christian Niessner <open...@christian-niessner.de>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Thu Mar 7 19:37:58 2013 +0100
Fix corner case in NTLM authentication (trac #172)
The problem is located in the file proxy.c within
"establish_http_proxy_passthru": To keep buffers small long
base64-encoded NTLM-Strings are truncated.
But the truncating is done on a wrong place: base 64 strings can be
cut every 4 chars. the buffer is 128 bytes - including the terminating
\0, so the usable data is only 127 bytes. And decoding a 127 char
base64 string fails... this is why the ntlm authentication fails in
certain cases (long strings)...
Acked-by: Joerg Willmann <j...@clnt.de>
URL: https://community.openvpn.net/openvpn/ticket/172
Signed-off-by: Gert Doering <g...@greenie.muc.de>
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgp7WKcaXFHA8.pgp
Description: PGP signature
