HI, On Sun, Feb 03, 2013 at 12:12:31PM +0100, Arne Schwabe wrote: > The construct_name_value function call will always fail so this code path is > never used. Since we now always have a valid environment in > static_context->c2.es it is better to have a ASSERT(es) than to call this > code patch. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org>
After some discussion, we (Gert, David, Arne) agreed to do it this way (ACK!)
- *if* we reach this point with es==NULL it's a bug, and we should
assert-crash in a way that makes it obvious where the real problem
is, and not "3 levels down in the buffer code"
- the offending code path was in the Android branch and does not affect
the "git openvpn" - but if we have more offending code, we want to
known, instead of silently ignoring it.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpRsjqr7LuEn.pgp
Description: PGP signature
