On 25/12/12 13:48, Gert Doering wrote: > Hi, > > On Sun, Dec 23, 2012 at 01:11:22PM +0100, Arne Schwabe wrote: >> I fear we may have to delay the final release. While debugging a problem >> with a user of my app I found a nasty bug which causes OpenVPN to crash >> if two PUSH_CONTROL messages are received. > > The appended patch fixes this for me (Client on Linux/i386, but that > should be OS and architecture agnostic).
Applied to master and beta/2.3
commit 1978db4b9657f0db134f1deaeb1e8400bf6a033e (master)
commit 2e3b853dd1070435d60a1f11ff4364631c83d6a9 (beta/2.3)
Author: Gert Doering <g...@greenie.muc.de>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Tue Dec 25 13:41:50 2012 +0100
Fix client crash on double PUSH_REPLY.
Introduce an extra bool variable c2.pulled_options_md5_init_done to
keep track of md5_init state of pulled_options_state - avoid accessing
uninitialized state when a second PUSH_REPLY comes in (which only happens
under very particular circumstances).
Bug tracked down by Arne Schwabe <a...@rfc2549.rrg>.
Signed-off-by: Gert Doering <g...@greenie.muc.de>
Acked-by: Arne Schwabe <a...@rfc2549.org>
Message-Id: 20121225124856.gt22...@greenie.muc.de
URL: http://article.gmane.org/gmane.network.openvpn.devel/7216
Signed-off-by: David Sommerseth <dav...@redhat.com>
--
kind regards,
David Sommerseth
signature.asc
Description: OpenPGP digital signature
