Hi Gert, On Wed, Dec 19, 2012 at 10:26:20PM +0100, Gert Doering wrote: > > On Mon, Dec 17, 2012 at 11:03:55PM +0100, Jeremie Le Hen wrote: > > I thereby kindly ask you to bring this patch in the source tree. I > > don't know about your release procedure, but it would be really nice if > > it could hit the tree before 2.3 is released. > > Thanks for the excessive links to documentation - it helps verifying > things. I agree that this is a useful last-minute correction and should > go in (feature-ACK). > > I don't particularily like the way your patch is coded, though, as it's > "all of them but Linux" that have "int" here (except Windows, which uses > DWORD, but the docs say "use QoS API instead") - too many #ifdefs. > > http://msdn.microsoft.com/en-us/library/windows/desktop/ms738586(v=vs.85).aspx > > so I'd propose to #ifdef it differently, patch appended.
Your patch looks fine to me. I went that way because I grep'ed the source for TARGET_ and saw similar occurences of what I did, though each part contained more lines :). Thanks for your review. Regards, -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons.
