Hi, On Tue, Dec 04, 2012 at 08:42:54PM +0100, Arne Schwabe wrote: > Fix the "WARNING: 'proto' is used inconsistently, local='proto UDP', > remote='proto UDPv6'." message. > > Note that the on wire strings are now always TCPv4 and UDPv4 to be compatible > to pre2.3
The patch does what advertised, so I ACK it, and it should go into 2.3
OTOH, I want to put up the question whether sending "proto foo" in the
occ option string is of any use *at all* - because if the --proto setting
on both ends do not match, the connection won't even reach the point
where it could recognize the fact that "oh, it's because incompatible
--proto settings!". So to achieve a null-feature, we have quite a bit
of code in "proto_remote()" in socket.c...
"Just throwing it out" for 2.3 will cause warnings with pre-2.3 clients
connecting to a (hypothetical) 2.3 server which does not send "proto",
(or vice versa).
What could do is to add some more code (sigh) to make OpenVPN 2.3 *ignore*
proto mismatches and missing "proto foo" strings in OCC, and stop sending
it in 2.4 altogether (so a 2.3<->2.4 combination would not warn, and
if 2.2<->2.4 warns, put it into the FAQ).
Maybe we should also add the same time stop warning about tun-ipv6 mismatches,
because the case where there server has tun-ipv6 configured, and the client
learns it due to "push tun-ipv6" will cause a useless warning today...
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpxPalBmx3Iz.pgp
Description: PGP signature
