Hi, On Sun, Sep 09, 2012 at 03:30:46AM +0200, David Sommerseth wrote: > From: David Sommerseth <dav...@redhat.com> > > When the server is configured with UDP and --push statements, reconnecting > often fails by the client never receiving PUSH_REPLY. The client sends > PUSH_REQUEST and the server logs these requests but does not send them. > > This bug got introduced in commit ff65da3a230b658b2c1d52dc1a48612e80a2eb42 > which tries to avoid sending duplicated PUSH messages if the client/server > connection is slow. > > This patch keeps this behaviour, but instead of a session wide PUSH_REPLY > block it sets an expiry time for the PUSH_REPLY block. The expiry time > is set to 30 seconds.
Looks good to me.
(I can see the reason why ff65da3a230b658b2c was implemented, and a
30-second-delay should handle these cases even for "normally" slow
servers or slow connections).
ACK.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgp9_oivrgDIK.pgp
Description: PGP signature
