Il 28.05.2012 10:52, Gert Doering ha scritto: > Hi > > On Sun, May 27, 2012 at 11:36:57PM +0300, Alon Bar-Lev wrote: >> t_client.sh requires root/sudo privileges. >> "make check" should not assume any special privilege. >> Because of this it is removed from "make check". >> You can still run this by hand or we can add special target such as >> "make root-check" or similar. > There was agreement by the developers to *have* this, and no explicit > agreement to *remove* it - you got an ACK for the patch, but I'm fairly > sure that it was not made clear that you removed t_client.sh functionality > while moving stuff around, because otherwise you would have seen NAKs.
It seems 34cb91 removed this functionality without explicitly mention anything about it. It was a massive patch that moved stuff around, which is why this change went unnoticed. Somebody please apply Gert's patch or provide an alternative patch, I'd need to setup connectivity tests for my buildslaves, too. I don't really care what the make target is called. It could even be an entirely different target. Buildslaves could easily run "make check" followed by "make root-check", "make connection-test" or whatever. If nobody outside the core project is supposed to run the connectivity tests, I think separating them from "make check" would make sense. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
