Looks good! I'll give it a feature ack. I don't see any problems in the autoconf code, but I'm not an expert in that area. So a tentative ack there too.
Adriaan > -----Original Message----- > From: Alon Bar-Lev [mailto:alon.bar...@gmail.com] > Sent: maandag 21 mei 2012 13:04 > To: openvpn-devel@lists.sourceforge.net > Cc: Alon Bar-Lev > Subject: [Openvpn-devel] [PATCH] build: check minimum polarssl version > > Pre 1.1 is unsupported, API was changed. > > Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> > --- > configure.ac | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac index 4592727..5ace128 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -743,6 +743,27 @@ if test -z "${POLARSSL_LIBS}"; then > ) > fi > > +if test "${with_crypto_library}" = "polarssl" ; then > + AC_MSG_CHECKING([polarssl version]) > + old_CFLAGS="${CFLAGS}" > + CFLAGS="${POLARSSL_CFLAGS} ${CFLAGS}" > + AC_COMPILE_IFELSE( > + [AC_LANG_PROGRAM( > + [[ > +#include <polarssl/version.h> > + ]], > + [[ > +#if POLARSSL_VERSION_NUMBER <= 0x01010000 #error invalid version > #endif > + ]] > + )], > + [AC_MSG_RESULT([ok])], > + [AC_MSG_ERROR([invalid polarssl version])] > + ) > + CFLAGS="${old_CFLAGS}" > +fi > + > AC_ARG_VAR([LZO_CFLAGS], [C compiler flags for lzo]) > AC_ARG_VAR([LZO_LIBS], [linker flags for lzo]) have_lzo="yes" > -- > 1.7.3.4 > > > ----------------------------------------------------------------------- > ------- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel
