On Wed, Nov 23, 2011 at 5:14 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 23 November 2011 14:53:06 Alon Bar-Lev wrote: >> As this is inserted into environment, what happens if locale is not >> unicode enabled? > > Then the script will receive funny looking strings depending on your locale's > code page. However, this is nothing that's being introduced with this patch, > as mentioned in the commit message 2627335 already puts UTF-8 user names and > passwords into the environment. > >> I think this may break some configurations. > > Aren't the environments lacking UTF-8 locales broken with regards to non-ASCII > characters anyways? As UTF-8 encoding doesn't change any character < 128 non- > ASCII DNs, user names and password will be passed to scripts just like in the > good old days.
Yes, there are many none unicode environments, and I am not sure what this patch will behave in windows environment as it is SCS-2 not UTF-8. OpenVPN is also used in embedded systems, such as dd-wrt.com and other. So I guess I would like to see unicode=true parameter on *NIX use UTF-8, on Windows use UCS-2. Alon.
