-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 21/11/11 13:07, Gert Doering wrote: > hi, > > On Mon, Nov 21, 2011 at 12:59:25PM +0100, David Sommerseth wrote: >> As the body of the check_subnet_conflict() function was disabled >> with an #if 0 clause, remove this function and clean up all places >> this function was called. >> >> This function also expected get_default_gateway() to return data, >> which it does not do any more. Hence this function is "out-of-date" >> and no longer usefull. > > I agree with the assessment, but come to a different conclusion - I > think the functionality is worthwile to have, so maybe we should try > to repair it, instead of throwing it out completely. > > Meeting topic?
Agreed, lets put this on the agenda. I've Cc'ed James, so that he can have a look at it too. This warning feature got disabled in commit 7fb0e07ec3f7c5f6514523085dbe02ea6b8933e2 [1], which refactored a lot of the depending code of check_subnet_conflict(). We would need to fix get_default_gateway() again. And further figure out what the reason for all those false positives. This commit doesn't change any behaviour, as this code is already removed via the #if 0. Hopefully most compilers won't bring in calls to an empty function (which is the current state of check_subnet_conflict() now) kind regards, David Sommerseth [1] <http://openvpn.git.sourceforge.net/git/gitweb.cgi?p=openvpn/openvpn-testing.git;a=commitdiff;h=7fb0e07ec3f7c5f6514523085dbe02ea6b8933e2> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7KQbkACgkQDC186MBRfrotHQCfWSA/TXLueXP5+fp3pjlDXBcp f2YAnjRuuc7WbPtT1Mgn+GtZbUC+Ewwp =k46c -----END PGP SIGNATURE-----
