-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 28/02/11 16:47, Stefan Hellermann wrote:
>>
>> Thanks a lot for this fix. Good catch!
>>
>> Applied to bugfix2.1 and merged into allmerged.
>>
>> commit 4c4b8cedfa98e8892a53eadd154836f8fa8cea7a
>> Author: Stefan Hellermann <ste...@the2masters.de>
>> Date: Sun Feb 27 22:15:44 2011 +0100
>>
>> Signed-off-by: Stefan Hellermann <ste...@the2masters.de>
>> Acked-by: David Sommerseth <dav...@redhat.com>
>> Signed-off-by: David Sommerseth <dav...@redhat.com>
>>
>>
>> You asked earlier if this patch was good, and I see you managed to add the
>> "Signed-off-by:" line (git commit -s). So this basically looks good to me!
>
> Sorry, the E-Mail with the Signed-off-by: was a patch v2, the last
> changed line has a ";" too much.
> The incremental diff:
>
> --- a/plugin.h
> +++ b/plugin.h
> @@ -176,7 +176,7 @@ plugin_call (const struct plugin_list *pl,
> struct plugin_return *pr,
> struct env_set *es,
> int current_cert_depth,
> - X509 *current_cert);
> + X509 *current_cert)
Gah! I managed to somehow mix stuff up. Sorry about that. I've applied a
new commit with this patch with you as the author and Signed-off-by. I'm
sorry about that mess. Even though I did a 'make distcheck' without
failures. But I might have missed a warning.
For patches which replaces earlier ones, please emphasize what the
difference is, then it easier to see that I work with the proper patches.
commit 2b7e41f39f54b68b515c9aa9053ca07bf54974a8
Author: Stefan Hellermann <ste...@the2masters.de>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Feb 28 16:53:26 2011 +0100
Fixed typo in plugin.h
A additional ';' had sneaked in commit 4c4b8cedfa98e8892a53. Lets
kick it out again.
Signed-off-by: Stefan Hellermann <ste...@the2masters.de>
Acked-by: David Sommerseth <dav...@redhat.com>
Signed-off-by: David Sommerseth <dav...@redhat.com>
Kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk1rxsIACgkQDC186MBRfro6RACfcuzzJ5b/kVXqMqLDJ6CPKQhF
/cwAnigYwfBBG1O1thR2kOqiVUoy21sr
=zN1n
-----END PGP SIGNATURE-----
