Lars Hupel wrote: > I would suggest to always send the Host header (even when HTTP/1.0 > is selected).
I strongly support this. Please watch out for HTTP/1.1, if a client claims to support 1.1 then servers can respond e.g. with chunked transfer coding, which certainly isn't supported by 1.0 clients. On the other hand, if OpenVPN only ever CONNECTs, maybe it's not an issue. Lars Hupel wrote: > As far as I can see, there are two possible hosts which can be sent: > > * 'host' (denoting the 'remote' config option) > * 'p->options.server' (denoting the 'http-proxy' config option) > > I would guess that sending the latter would be correct, but the > OpenVPN sources use the first one. Current behavior is correct. The first one is what should be sent. > The section about the host header isn't very helpful either: > > > The Host request-header field specifies the Internet host and port > > number of the resource being requested, as obtained from the original > > URI given by the user or referring resource (generally an HTTP URL Actually it is helpful. It says that *the resource being requested as obtained from the original URI given by the user* is what should be sent. This is the "remote" parameter and nothing else. I'll ack your patch if it only adds a Host header where one is missing, and sends the correct contents, ie. the "remote" hostname. //Peter
