Hi,
On Wed, Aug 18, 2010 at 03:27:45PM +0200, Matthias Andree wrote:
> > +if [ -r ./t_client.rc ] ; then
> > + . ./t_client.rc
> > +elif [ -r "${srcdir}"/t_client.rc ] ; then
> > + . "${srcdir}"/t_client.rc
> > +else
> > + echo "$0: cannot find 't_client.rc' in current directory or" >&2
> > + echo "$0: source dir ('${srcdir}'). SKIPPING TEST." >&2
> > + exit 77
> > +fi
>
> I have occasionally been bitten by such ambiguities between current working
> directory and $srcdir. I'd propose to steer clear of such precedence rules.
I'm using this on purpose here - I have a number of machines that build
using the same $srcdir (mounted over NFS), and one of them has no working
IPv6-over-tun. So this special machine has a t_client.rc in its
build directory which sources $srcdir/t_client.rc and subsequently
unsets all IPv6-related test targets.
So all machines can use the same generic t_client.rc, and if I need to
fiddle with things on individual hosts, I can do so, without having to
maintain a "nearly identical" copy on all machines.
> > if [ -z "$CA_CERT" ] ; then
> > echo "CA_CERT not defined in 't_client.rc'. SKIP test." >&2
> > exit 0
>
> I think you missed this "exit 0" - should also be 77 instead - and please
> check
> if there are more (I've not been looking at the source script for lack of
> time).
There are some more.
David, could you patch these as well? Otherwise I need to go cherrypicking
your changes first (and this might take longer).
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
