-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 29/04/10 09:03, Gert Doering wrote: > Hi, > > On Thu, Apr 29, 2010 at 01:02:37PM +0900, Kazuyoshi Aizawa wrote: >> I've attached a patch for tun.c which includes support for tap >> interface for solaris/opensolaris. >> The code is based on OpneVPN 2.1.1. And it has a routine to >> plumb/unplumb tap interface like ifconfig command. >> >> tap driver for solarsi/opensolaris is here: >> http://www.whiteboard.ne.jp/~admin2/tuntap/ > > Thanks for your work!. I have already used bits from there when adding > IPv6 payload support to OpenVPN on Solaris :-) > > Question to the community: how do we want to integrate the tun.c changes > for Solaris? Its own branch, feat_misc branch, feat_ipv6_payload branch? > > If we include it in feat_ipv6_payload, it won't have merge conflicts - but > then you only get the TAP-on-Solaris in combination with all the IPv6 stuff, > which people might not want. > > David?
You seem to have pretty well good control over this TUN/TAP infrastructure. So I have no problems with you pulling whatever you find useful into your IPv6 branch, which covers this. If given a separate branch, I'm not going to be the one who solves potential conflicts unless they're bloody obvious and trivial. So I'll just be going to push someone to fix these branches so they can be merged. Gert, I'll let you know decide if you feel this is good for inclusion into your tree. If you prefer to have it separately, including the work needed to make these branches merge-able, I'm fine with that. It's easier to track things if they have separate branches, but if this patch is close to what you do in your tree, I don't see it that important to split it out. kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkvZPUsACgkQDC186MBRfrpElQCdHZPAXh0LuPfiKtNWRt2+e6IK UEIAnjXlVySWFUgOxxhU3bCp3mv5hlSI =SydE -----END PGP SIGNATURE-----
