-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 19/04/10 23:37, Davide Brini wrote: > On Monday 19 April 2010, David Sommerseth wrote: > >> I've done a quick test on one of my connections on Fedora 12 without any >> resolvconf package (meaning it invokes the simple cp approach), and it >> worked like a charm. >> >> Applied to bugfix2.1 and merged into allmerged. >> Commit a9c9a89e96dc1e4e843e05ecadc4349b81606b06 > > Sorry, I just realized that I didn't change the sha-bang line in client.down. > Apologies. Fix attached.
No problem! And thanks a lot for fixing it! I should have caught that one during my review as well. I looked at "everything", but managed to not notice this one as well. Anyway, I gave it an ACK and it's now in the bugfix2.1 branch. As this is a non-critical fix, I'll delay pushing it to allmerged until more patches comes in. You'll find it as commit 2d9c14b435ae4083aa3f6bce803ede27cce2b6cb For future patches, would you mind adding a little bit more descriptive text which can be used as commit log messages. I do write those commit logs when I find it is needed, but adding a little bit more descriptions of what the patch does is a nice and good habit - no matter how easy the patch looks like ... and it makes my maintenance job a lot easier and quicker. I won't reject good patches due to missing commit messages, but it I'm not picking these patches first for inclusion - as they require more work. So the easier the patches are for me to work with, the quicker they go into the tree after the required review. kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkvQAowACgkQDC186MBRfrrhCQCfdrZTU2ilBNQ+K8FC8iDguloq X04An0/BxnoqesB1CqCS+BzYdreb8rrh =q4xW -----END PGP SIGNATURE-----
