David Sommerseth schrieb: > On 01/04/10 10:32, Fabian Knittel wrote: >> We'll definitely be doing that over here. My main concern was whether >> we would have to patch OpenVPN indefinitely with local enhancements or >> whether there was a chance to include it upstream. And now that things >> look quite positive, we can go forward with the chosen approach. :) > > Thanks a lot! This really will help us a lot. If you even dare to try > a local merge against the 'allmerged' branch when you do some bigger > tests, that would also be very much appreciated.
OK. I assume feat_passtos isn't merged into allmerged yet, right? I'll probably pluck Davide Guerri's patch from feat_passtos and do the testing together with my vlan patches on allmerged. (Assuming things don't explode too badly on allmerged :).) > Btw! How is it with IPv6 and your patches? We have quite some patches > for that in the tree already. And as I see you patch in the [PATCH 1/9] > the is_ipv4() function, you might want to be sure this will also work in > the IPv6 world as well. AFAICS, IPv6 support for tap should only come into the picture when we attempt to inspect the packets for specific purposes, like packet filtering or retrieving the packet's priority (TOS in IPv4). So although the patches don't yet explicitly handle IPv6, I don't expect them to conflict with it either... I'll have a look when I merge to allmerged. And we'll be testing autoconfigured IPv6 addresses over tap in our setup, so we'll hopefully catch obvious problems. >> Sounds great! I'll definitely continue polishing the patch-set and >> continue hitting the vlan code with more tests. > > Cool! Please let me know if you patches will go on top of the current > patch-set you sent, or if you come with a new patch-set based upon the > feat_passtos branch. I'd be fine with whatever you would prefer ... If you have no preferences, I'd probably continue rebasing my internal branch on feat_passtos until all comments have been worked in and we've completed our basic tests. But I can also use a more incremental approach, if that simplifies your reviewing work or you'd like the existing code to be visible on openvpn-testing.git. Cheers Fabian
signature.asc
Description: OpenPGP digital signature
