-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 19/02/10 15:21, JuanJo Ciarlante wrote: > On Fri, Feb 19, 2010 at 2:46 PM, Gert Doering <g...@greenie.muc.de> wrote: [...snip...] >> The existing >> code doesn't do reverse DNS lookups for IPv4 mroute printing, and so >> the IPv6 code should behave similar to the IPv4 code, and not do DNS >> either (also, depending on DNS lookup in this place might lead to >> weird delays in unexpected situations). But this is partly religious, >> partly "follow the coding style of the existing code" stuff. > > IMO we should void using inet_ntop() and friends, personally > I don't like locking around their lack of multi-threading.
I believe this is a general discussion which will come often up. Even though OpenVPN is not multi-threaded today, there are no guarantee that this will not change. If we get an implementation which will handle multi-threading, I will favour that one. I believe OpenVPN will in the future need to bite the (bitter?) apple and really look into threading. So I lean towards JJO here, as far as possible, avoid using functions which are not thread safe. [...snip...] Kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkt+oYEACgkQDC186MBRfrp6FQCeLSKI7OVRHzj09+ATRpP31Lbn pz0An2X4oqoGbu8syFHmLP5vxqHDAt2p =qQXQ -----END PGP SIGNATURE-----