Thanks a lot Samuli. I cloned "openvpn-build" repo yesterday and created my patch branch off the last commit on "release/2.3" but after reading your email I checked it out again and saw that my "release/2.3" was actually 1 commit behind the origin. I am still trying to understand how this difference happened but yeah, my patch is not necessary.
Regarding the contribution process, I was reading https://community.openvpn.net/openvpn/wiki/CodeRepositories page which states: "All bug fixes should be developed against the master branch, and where it is decided to include such fixes in a minor release (2.1.x, 2.2.x, etc), it will be cherry-picked from the master branch and into the suitable release branches.". This is what made me thinking I should create a patch for "master" rather than "release/2.3". Did you suggest using release branch as a target because my patch was not a bug fix (but a simple build parameter update)? Bojan On Mon, Aug 29, 2016 at 9:26 AM, Samuli Seppänen <sam...@openvpn.net> wrote: > Il 29/08/2016 11:05, Bojan Komazec ha scritto: > >> This is my first attempt to contribute to OpenVpn project. Please let me >> know if I am doing it right. >> > > Forgot to thank you for your contribution, so here it comes: thank you! :) > > When you contribute to openvpn-gui, openvpn-build or easy-rsa you can use > GitHub pull requests. These PRs will be reviewed an merged in the typical > GitHub fashion. > > Even when contributing to the main OpenVPN project you can send a PR, > which will then get reviewed in GitHub. Later, when/if the PR has been > ACKed (=accepted), the patch needs to be sent to this list using > git-send-email for the final comments (if any), and merged to the codebase. > Älternatively you can just send the patch to this list, like you did now. > > -- > Samuli Seppänen > Community Manager > OpenVPN Technologies, Inc > > irc freenode net: mattock > > > >> Thanks, >> Bojan >> >> On Sun, Aug 28, 2016 at 9:18 PM, Bojan Komazec <bojan.koma...@gmail.com >> <mailto:bojan.koma...@gmail.com>> wrote: >> >> OpenVPN/openvpn-build has to be updated so it fetches and builds >> OpenVpn v2.3.12. >> >> From 87a0ca6307ea9c772fc5fa584efc2f2f0f3805a8 Mon Sep 17 00:00:00 >> 2001 >> From: Bojan Komazec <bojan.koma...@gmail.com >> <mailto:bojan.koma...@gmail.com>> >> Date: Sun, 28 Aug 2016 20:49:02 +0100 >> Subject: [PATCH] Updated build parameters to match >> openvpn-install-2.3.12-I601 >> >> Signed-off-by: Bojan Komazec <bojan.koma...@gmail.com >> <mailto:bojan.koma...@gmail.com>> >> --- >> generic/build.vars | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/generic/build.vars b/generic/build.vars >> index ed93a0b..9d44d06 100644 >> --- a/generic/build.vars >> +++ b/generic/build.vars >> @@ -5,7 +5,7 @@ OPENSSL_VERSION="${OPENSSL_VERSION:-1.0.1t}" >> PKCS11_HELPER_VERSION="${PKCS11_HELPER_VERSION:-1.11}" >> LZO_VERSION="${LZO_VERSION:-2.09}" >> TAP_WINDOWS_VERSION="${TAP_WINDOWS_VERSION:-9.21.2}" >> -OPENVPN_VERSION="${OPENVPN_VERSION:-2.3.11}" >> +OPENVPN_VERSION="${OPENVPN_VERSION:-2.3.12}" >> OPENVPN_GUI_VERSION="${OPENVPN_GUI_VERSION:-10}" >> >> OPENSSL_URL="${OPENSSL_URL:-http://www.openssl.org/source/o >> penssl-${OPENSSL_VERSION}.tar.gz >> <http://www.openssl.org/source/openssl-$%7BOPENSSL_VERSION%7D.tar.gz >> >}" >> -- >> 2.9.2.windows.1 >> >> >> >> >> > >
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
