Hi,

On Thu, Aug 25, 2016 at 11:54:57PM +0200, David Sommerseth wrote:
> Commit b3e975824ea9ebae8dbea5b451c8d02525c83ffe moved the finalizing of
> TCP/UDP sockets before the UID/GID where dropped.  But this did not
> factor that the timeout code had been revamped [1] in the mean time.
> 
> This ensures the timout initialization is done before the the socket
> finalizing has been completed.
> 
> [1] commit f2134b7bea37df15756c599b94f16d4bffafbbd6

This looks reasonable, and fixes the issue for me - in other words,
my tests are happy

Test sets succeded: 1 1a 1b 1c 1d 2 2a 2b 2d 3 4 4a 5 8 9.
Test sets failed: none.


If we keep the other one (Arne had some reservations because the amount
of code in the "now-privileged" part is bigger than "just bind"), then
this is a working fix - so, conditional ACK.

gert

-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to