On Mar 13, 2012, at 11:54 AM, Josh Kearney wrote:
> On Tue, Mar 13, 2012 at 5:07 AM, Soren Hansen <so...@linux2go.dk> wrote: > 2012/3/13 Jesse Andrews <anotherje...@gmail.com>: > > Maybe it is just me, but most reviews seem to take hours to days to > > complete. I'm been sitting here waiting for a one line change to get > > a second "+2 / approved" so I can redeploy our test cluster for the > > last 2 hours. > > Can we keep this discussion separate, please? I acknowledge it can be > difficult getting stuff approved (or even reviewed), but that's a > separate (yet just at real) problem. > > Actually I think this applies to the current discussion. If we're going to > look at things that need improving, we should be focusing on how to fix the > above issue before we worry about adding more constraints to the Core > workflow. As long as we're talking about review issues, I'd really like to have a set of reviewing guidelines. Even better would be to have them in checklist form to make sure we don't miss things as we do reviews (checklists are great: http://gawande.com/the-checklist-manifesto). Take care, Lorin -- Lorin Hochstein Lead Architect - Cloud Services Nimbis Services, Inc. www.nimbisservices.com
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
