----- Original Message ----- > From: "Joe Gordon" <j...@cloudscaling.com> > To: openstack@lists.launchpad.net > Sent: Monday, March 12, 2012 5:59:02 PM > Subject: [Openstack] Gerrit minimum review time frame > > Hi All, > > I have noticed that some Gerrit branches get approved very quickly, > sometimes in a matter of minutes. While most of the time these > branches > are vetted properly, the window for reviewing can be so small that a > non-trivial branch lands but without enough vetting. If someone is > in a > meeting for half on hour they may miss the entire review window. To > fix > this problem I propose a minimum time frame (should be overridable in > an > emergency) for a branch to be approved, perhaps 2 hours. This time > frame > would start on 'Upload time.' > > best, > Joe Gordon >
I'd be a fan of this. Giving everyone a fair shot at making a comments both positive and negative sounds like a great idea. Perhaps this is something to bring up at the conference? About how to enforce this? policy vs. procedure, etc. I'm not sure tying a core everyone's hands is the best idea. >From my prospective I'd love to have a shot at "smoking" more branches w/ >SmokeStack. Once those "breaking" commits land it makes it that much harder to >classify merge props. Dan > _______________________________________________ > Mailing list: https://launchpad.net/~openstack > Post to : openstack@lists.launchpad.net > Unsubscribe : https://launchpad.net/~openstack > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
