On 2017-05-30 12:53:15 -0700 (-0700), Jesse Keating wrote: [...] > Github labels: This is like approvals/reviews. [...]
Perhaps an interesting aside, Gerrit uses the same term (labels) for how we're doing approvals and review voting. > Personally, my opinions are that to avoid confusion, change type > requirements should always fail on push type events. This means > open, current-patchset, approvals, reviews, labels, and maybe > status requirements would all fail to match a pipeline for a push > type event. It's the least ambiguous, and promotes the practice of > creating a separate pipeline for push like events from change like > events. I welcome other opinions! This seems like a reasonable conclusion to me. -- Jeremy Stanley _______________________________________________ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
