On 22/08/14 13:20, Clark Boylan wrote:
> On Thu, Aug 21, 2014, at 09:26 PM, Tom Fifield wrote:
>> Hi Infra,
>>
>> I vaguely recall a discussion where it was stated that should someone
>> come up with a better phrase for the -1 text ("I would prefer that you
>> didn't merge this"), we could change the text to that.
>>
>> The below suggestion has a few people agreeing with it. Perhaps we could
>> put in a patch to change the text, and see how it goes?
>>
>> Regards,
>>
>>
>> Tom
>>
>>
>> -------- Forwarded Message --------
>> Subject: Re: [openstack-dev] Criteria for giving a -1 in a review
>> Date: Thu, 21 Aug 2014 17:21:19 +0100
>> From: Daniel P. Berrange <berra...@redhat.com>
>> Reply-To: Daniel P. Berrange <berra...@redhat.com>, OpenStack
>> Development Mailing List (not for usage questions)
>> <openstack-...@lists.openstack.org>
>> To: OpenStack Development Mailing List (not for usage questions)
>> <openstack-...@lists.openstack.org>
>>
>> On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
>>> "I would prefer that you didn't merge this."
>>>
>>> i.e. The project is better off without it.
>>
>> A bit off topic, but I've never liked this message that gets added
>> as it think it sounds overly negative. It would better written
>> as
>>
>> "This patch needs further work before it can be merged"
>>
>> as that gives a positive expectation that the work is still
>> wanted by the project in general
>>
>> _______________________________________________
>> OpenStack-Infra mailing list
>> OpenStack-Infra@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
>
> Unfortunately, the actual file that needs to be edited to enact this
> change isn't managed by our tooling. We still curate by hand because of
> a chicken and egg issue managing the All-Projects ACL file (you can't
> manage the file until you have the file in place...). But we do document
> what we expect to be in that file. I have gone ahead and proposed
> https://review.openstack.org/#/c/116176 and we can argue over the value
> there. If we agree one of the gerrit admins can update the All-Projects
> ACL file.
Awesome! I'll link your patch to the appropriate point in the thread.
_______________________________________________
OpenStack-Infra mailing list
OpenStack-Infra@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
