Hi, my colleague Jaroslav pointed out, that his change did not get properly linked to, from launchpad bugs.
Review https://review.openstack.org/#/c/105105/ should get links in https://bugs.launchpad.net/python-novaclient/+bug/1227694 https://bugs.launchpad.net/python-novaclient/+bug/1343991 None of them got link comment. bug 1227691 has just a link to different change (older, already abandoned). I've figured out jeepyb/cmd/update_bug.py could be responsible for this, and called as gerrit local hook on change/patchset. Is that correct please? But I have no idea why it did not worked in this case. How can I proceed with debugging this? update_bug.py in jeepyb seems to depend on connection to LP and to local repo, quite heavily, any suggestion how to try it in dry-run mode localy (without rewriting all the code)? Btw I've noticed that act. only 1227694 should get the link, as it was contained in the first patchset's commit message, the other (91) was in some later patchset, and in https://github.com/openstack-infra/jeepyb/blob/master/jeepyb/cmd/update_bug.py#L262 I've found that comment for proposed fix happens only for first patchset. I think I understand why (not spamming with same change again and again), but, as in this change, new bug numbers may be added to commit msg later, was it considered to try to do something like 'go over older comments and send new one if this change was not yet mentioned in them'? Would it be too expensive thing to do (in regards to for ex. time, requests to lp, ...)? Best regards -- Pavel Sedlák <[email protected]> OpenStack Quality Engineer Red Hat Czech / BRQ irc: psedlak _______________________________________________ OpenStack-Infra mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
